Skip to content

feat: improve locality of defaults (#1352) #1560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 2, 2022
Merged

feat: improve locality of defaults (#1352) #1560

merged 5 commits into from
Feb 2, 2022

Conversation

XDRAGON2002
Copy link
Contributor

Fixes #1352

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2022 •
edited
Loading

Codecov Report

Merging #1560 (bde7882) into main (7dd0d75) will not change coverage.
The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1560   +/-   ##
=======================================
  Coverage   80.34%   80.34%           
=======================================
  Files         281      281           
  Lines        5581     5581           
  Branches      911      913    +2     
=======================================
  Hits         4484     4484           
  Misses        899      899           
  Partials      198      198
Flag Coverage Δ
longtests 80.34% <50.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cve_bin_tool/helper_script.py 41.29% <0.00%> (ø)
cve_bin_tool/cli.py 71.42% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7dd0d75...bde7882. Read the comment docs.

@XDRAGON2002 XDRAGON2002 mentioned this pull request Jan 29, 2022
Closed
@XDRAGON2002 XDRAGON2002 marked this pull request as draft January 29, 2022 12:58
@XDRAGON2002 XDRAGON2002 marked this pull request as ready for review January 29, 2022 13:15
terriko
terriko approved these changes Feb 2, 2022
View reviewed changes
Copy link
Contributor

@terriko terriko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

laugh code reviewing this was a pain in the butt for exactly the reason #1352 was filed. Wound up having to have two side-by-side copies of the PR so I could compare lists and make sure none of the values were being changed by accident.

We might want to spend time thinking about "" vs None in some future refactoring, but that's out of scope for this PR.

@terriko terriko merged commit 611aeec into intel:main Feb 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terriko terriko terriko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: ArgumentParser and defaults
3 participants
@XDRAGON2002 @codecov-commenter @terriko